Repository navigation
Feat: Find the window's views and widget by reflection, not row values - #222
Merged
Merged
Conversation
The browser layout's host view, page area and contents view are found as the fields that hold the views named BrowserView, MainBackgroundRegionView and MultiContentsView. The frame view's browser view field is the one that holds that same view. A view's widget is the one the root of its view tree names, so it needs no vtable slot. A view's parent and children fields come from the reflect view walk, confirmed by the bounds offset. Row values only cross check what was found, and a disagreement uses neither. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…rying them The frame view's browser view field, the layout's host view, page area and contents container, and View::GetWidget's slot are found by the runtime. A port that cannot read them from the new build leaves them out, so they no longer stop the row. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Edge 157.0.4341.60 row was blocked by five values the window cannot do without. The runtime now finds each one from the browser's own memory, using public Chromium source:
side_panel.host_view,side_panel.page_area,side_panel.contents_container: the fields of the layout'sBrowserViewLayoutViewsthat hold the views namedBrowserView,MainBackgroundRegionViewandMultiContentsView. A child view must also name the browser view as its parent.layout.frame_browser_window_offset: the frame view field (BrowserFrameView::browser_view_) that holds the view the layout lays out. Before the first layout, it is the field whose view's children all name it as their parent.toolbar.get_widget_slot: the widget is the one the root view names (RootView::widget_), andWidget::root_view_must point back at it. No vtable slot is needed.app_window.view_parent/view_children: these come from thereflect.rsview walk, which runs once per build on a worker thread. The bounds offset member order now only cross checks them.When the row has a value, it must match what reflection found, or neither is used. The row generator now leaves these five values out of a row instead of carrying them, so they no longer block it. Older runtimes cannot read rows without them. They refuse the row and fall back to the held build.
Tests (in memory):
nfr6_the_side_panel_views_are_found_by_class_name,nfr6_a_views_widget_is_found_without_a_vtable_slot,nfr6_the_frame_view_field_is_the_one_holding_the_browser_view,nfr6_a_reflected_value_must_agree_with_the_row,nfr6_a_row_without_window_offsets_is_not_blocked(row data and port), and others.Nothing was built or tested in the worktree. The tests and the Edge 157 row run still need to be run on develop.
🤖 Generated with Claude Code